On 10/14/2026 12:48 PM, Philippe Mathieu-Daudé wrote: > On 14/10/26 20:25, Pierrick Bouvier wrote: >> Now that all targets implement this interface, we can replace function >> calls with the new interface. >> >> Reviewed-by: Brian Cain <[email protected]> >> Signed-off-by: Pierrick Bouvier <[email protected]> >> --- >> semihosting/arm-compat-semi.c | 56 +++++++++++++++++------------------ >> 1 file changed, 28 insertions(+), 28 deletions(-) >> >> diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat- >> semi.c >> index b930a028649..3117eadb3b7 100644 >> --- a/semihosting/arm-compat-semi.c >> +++ b/semihosting/arm-compat-semi.c >> @@ -188,7 +188,7 @@ static LayoutInfo common_semi_find_bases(CPUState >> *cs) >> */ >> #define GET_ARG(n) do { \ >> - if (is_64bit_semihosting(env)) { \ >> + if (cs->cc->semi_ops->is_64bit(cs)) { \ > > No semi_ops / handler NULL deref checks, SEGV as implementation error > sounds OK but might deserve a comment in the commit description.
I'll add it.
