On Tue, Oct 13, 2026 at 05:50:03PM +0100, Peter Maydell wrote: > On Thu, 1 Oct 2026 at 11:52, Aastha Rawat > <[email protected]> wrote: > > > > From: "Anirudh Rayabharam (Microsoft)" <[email protected]> > > > > Add the main vCPU run loop for MSHV using the MSHV_RUN_VP_IOCTL. > > > > Handle MMIO exits by emulating the instruction using the syndrome > > information from ESR_EL2. > > > > Signed-off-by: Anirudh Rayabharam (Microsoft) <[email protected]> > > --- > > include/hw/hyperv/hvgdk_mini.h | 44 +++++++++++++++++ > > target/arm/mshv/mshv-all.c | 107 > > +++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 151 insertions(+) > > > > diff --git a/include/hw/hyperv/hvgdk_mini.h b/include/hw/hyperv/hvgdk_mini.h > > index 33c9e4f3e0..53dc58813e 100644 > > --- a/include/hw/hyperv/hvgdk_mini.h > > +++ b/include/hw/hyperv/hvgdk_mini.h > > @@ -896,6 +896,50 @@ struct hv_x64_memory_intercept_message { > > uint8_t instruction_bytes[16]; > > } QEMU_PACKED; > > > > +union hv_arm64_vp_execution_state { > > + uint16_t as_uint16; > > + struct { > > + uint16_t cpl:2; > > + uint16_t debug_active:1; > > + uint16_t interruption_pending:1; > > + uint16_t vtl:4; > > + uint16_t virtualization_fault_active:1; > > + uint16_t reserved:7; > > + }; > > +}; > > This is an mshv specific file, but I would still recommend against > bitfields-in-a-union as generally bad style.
Hi Peter, We source these definitions pretty much verbatim from the hypervisor headers. Having them as close as possible to the hypervisor headers would it make it easier to maintain. We do make some cosmetic changes w.r.t naming style and QEMU_PACKED instead of __packed__ etc but that's about it. Alsoe, there are existing definitions in this file using the same style. Thanks, Anirudh.
