On 10/16/2026 3:59 AM, Philippe Mathieu-Daudé wrote: > On 16/10/26 08:42, Pierrick Bouvier wrote: >> On 10/15/26 10:59 PM, Philippe Mathieu-Daudé wrote: >>> On 15/10/26 23:32, Pierrick Bouvier wrote: >>>> This series removes duplication of cpu_get_note_size and >>>> cpu_get_dump_info per >>>> target. For this, we define a new set of Dump operations for a given >>>> cpu, and >>>> implement it per target. >>>> >>>> Existing implementations were using first_cpu, which is what we >>>> continue to do. >>>> When we'll work on heterogeneous later, we can revisit this to >>>> either forbid a >>>> dump, or perform a dump for each target active. >>> >>> Make sense but this must be documented, in the code, and commits >>> description. >>> >>> Maybe we can self-document adding '#define qemu_heterogeneous() false' >>> in a core header and asserting !qemu_heterogeneous() in the dump API? >> >> I can add a new function target_heterogenenous in target_info, which >> returns false for now. And add this check in the if for those dump >> operations, saying it's not supported in this case. >> >> What do you think? > > Yes please it is cheap and that'd make us safer IMHO.
Ok, I'll add this for v3. Regards, Pierrick
