Hi, With the tests/tcg rework that went in recently, we now see the results of make check-tcg tests as part of make check output, which is a nice addition so thank you for that! Of course, it did expose a few problems in the non-container environment that I'd like to consider here.
- Patch 1 addresses an endianness problem that shows up when running on a big-endian (s390) host. It's existed for a while, as I can recreate similar errors (if slightly different messages) at least back to 11.0.0. Just never noticed (or looked into it) before. - Patches 2-4 addresses a change in behavior that occurs in the powerpc toolchain between power6 and power7 (based on experimentation with gcc -mcpu= settings). The tests as they currently are run fine for me on either an s390 or x86 host running Fedora, but fail on both hosts running Debian. I opted to disable the tests up front, and then add the problematic tests one at a time, since passing a cpu generation to the compiler changes the expected reference output. Can't say I understand the details of the ppc64 compiler behavior, but this gets make check-tcg running cleanly in all my configs. Eric Farman (4): hw/i386: ELF endianness fixes tests/tcg/ppc64: Skip float_conv* tests tests/tcg/ppc64: Add float_convd test tests/tcg/ppc64: Add float_convs test hw/i386/x86-common.c | 6 +- include/hw/elf_ops.h.inc | 20 ++++- tests/tcg/ppc64/float_convd.ref | 144 ++++++++++++++++---------------- tests/tcg/ppc64/float_convs.ref | 80 +++++++++--------- tests/tcg/ppc64/meson.build | 11 +++ 5 files changed, 145 insertions(+), 116 deletions(-) -- 2.53.0
