On Mon, Oct 05, 2026 at 01:08:52PM +0100, Daniel P. Berrangé wrote: > diff --git a/target/hppa/trace-events b/target/hppa/trace-events > index 01761a4559b..7c897610a9e 100644 > --- a/target/hppa/trace-events > +++ b/target/hppa/trace-events > @@ -1,19 +1,19 @@ > # See docs/devel/tracing.rst for syntax documentation. > > # mem_helper.c > -disable hppa_tlb_flush_ent(void *env, void *ent, uint64_t va_b, uint64_t > va_e, uint64_t pa) "env=%p ent=%p va_b=0x%lx va_e=0x%lx pa=0x%" PRIx64 > -disable hppa_tlb_find_entry(void *env, void *ent, int valid, uint64_t va_b, > uint64_t va_e, uint64_t pa) "env=%p ent=%p valid=%d va_b=0x%lx va_e=0x%lx > pa=0x%" PRIx64 > -disable hppa_tlb_find_entry_not_found(void *env, uint64_t addr) "env=%p > addr=%08lx" > -disable hppa_tlb_get_physical_address(void *env, int ret, int prot, uint64_t > addr, uint64_t phys) "env=%p ret=%d prot=%d addr=0x%lx phys=0x%lx" > -disable hppa_tlb_fill_excp(void *env, uint64_t addr, int size, int type, int > mmu_idx) "env=%p addr=0x%lx size=%d type=%d mmu_idx=%d" > -disable hppa_tlb_fill_success(void *env, uint64_t addr, uint64_t phys, int > size, int type, int mmu_idx) "env=%p addr=0x%lx phys=0x%lx size=%d type=%d > mmu_idx=%d" > -disable hppa_tlb_itlba(void *env, void *ent, uint64_t va_b, uint64_t va_e, > uint64_t pa) "env=%p ent=%p va_b=0x%lx va_e=0x%lx pa=0x%" PRIx64 > -disable hppa_tlb_itlbp(void *env, void *ent, int access_id, int u, int pl2, > int pl1, int type, int b, int d, int t) "env=%p ent=%p access_id=%x u=%d > pl2=%d pl1=%d type=%d b=%d d=%d t=%d" > -disable hppa_tlb_ptlb(void *env) "env=%p" > -disable hppa_tlb_ptlb_local(void *env) "env=%p" > -disable hppa_tlb_ptlbe(void *env) "env=%p" > -disable hppa_tlb_lpa_success(void *env, uint64_t addr, uint64_t phys) > "env=%p addr=0x%lx phys=0x%lx" > -disable hppa_tlb_lpa_failed(void *env, uint64_t addr) "env=%p addr=0x%lx" > +hppa_tlb_flush_ent(void *env, void *ent, uint64_t va_b, uint64_t va_e, > uint64_t pa) "env=%p ent=%p va_b=0x%lx va_e=0x%lx pa=0x%" PRIx64 > +hppa_tlb_find_entry(void *env, void *ent, int valid, uint64_t va_b, uint64_t > va_e, uint64_t pa) "env=%p ent=%p valid=%d va_b=0x%lx va_e=0x%lx pa=0x%" > PRIx64 > +hppa_tlb_find_entry_not_found(void *env, uint64_t addr) "env=%p addr=%08lx" > +hppa_tlb_get_physical_address(void *env, int ret, int prot, uint64_t addr, > uint64_t phys) "env=%p ret=%d prot=%d addr=0x%lx phys=0x%lx" > +hppa_tlb_fill_excp(void *env, uint64_t addr, int size, int type, int > mmu_idx) "env=%p addr=0x%lx size=%d type=%d mmu_idx=%d" > +hppa_tlb_fill_success(void *env, uint64_t addr, uint64_t phys, int size, int > type, int mmu_idx) "env=%p addr=0x%lx phys=0x%lx size=%d type=%d mmu_idx=%d" > +hppa_tlb_itlba(void *env, void *ent, uint64_t va_b, uint64_t va_e, uint64_t > pa) "env=%p ent=%p va_b=0x%lx va_e=0x%lx pa=0x%" PRIx64 > +hppa_tlb_itlbp(void *env, void *ent, int access_id, int u, int pl2, int pl1, > int type, int b, int d, int t) "env=%p ent=%p access_id=%x u=%d pl2=%d pl1=%d > type=%d b=%d d=%d t=%d" > +hppa_tlb_ptlb(void *env) "env=%p" > +hppa_tlb_ptlb_local(void *env) "env=%p" > +hppa_tlb_ptlbe(void *env) "env=%p" > +hppa_tlb_lpa_success(void *env, uint64_t addr, uint64_t phys) "env=%p > addr=0x%lx phys=0x%lx" > +hppa_tlb_lpa_failed(void *env, uint64_t addr) "env=%p addr=0x%lx" > > # op_helper.c > -disable hppa_tlb_probe(uint64_t addr, int level, int want) "addr=0x%lx > level=%d want=%d" > +hppa_tlb_probe(uint64_t addr, int level, int want) "addr=0x%lx level=%d > want=%d"
>From docs/devel/tracing.rst: Format strings should reflect the types defined in the trace event. Take special care to use PRId64 and PRIu64 for int64_t and uint64_t types, respectively. This ensures portability between 32- and 64-bit platforms. These format strings apply %lx to uint64_t arguments. This won't work on 32-bit or the Windows LLP64 data model. The format strings must use PRIx64 instead of "lx". We probably didn't notice before because they were disabled :). Stefan
