On 10/20/2026 6:37 PM, Philippe Mathieu-Daudé wrote: > On 19/10/26 23:26, Pierrick Bouvier wrote: >> This allows to use a forward declaration instead of including >> system/dump-arch.h. >> >> Reviewed-by: Marc-André Lureau <[email protected]> >> Signed-off-by: Pierrick Bouvier <[email protected]> >> --- >> include/qemu/typedefs.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h >> index 2344c92182e..8fa7f752dac 100644 >> --- a/include/qemu/typedefs.h >> +++ b/include/qemu/typedefs.h >> @@ -28,6 +28,7 @@ typedef struct AddressSpace AddressSpace; >> typedef struct AioContext AioContext; >> typedef struct Aml Aml; >> typedef struct ArchCPU ArchCPU; >> +typedef struct ArchDumpInfo ArchDumpInfo; >> typedef struct BdrvDirtyBitmap BdrvDirtyBitmap; >> typedef struct BdrvDirtyBitmapIter BdrvDirtyBitmapIter; >> typedef struct BlockBackend BlockBackend; > > Remove it of "system/dump-arch.h": > > -- >8 -- > diff --git a/include/system/dump-arch.h b/include/system/dump-arch.h > index 743916e46ca..7165a5bbd03 100644 > --- a/include/system/dump-arch.h > +++ b/include/system/dump-arch.h > @@ -14,7 +14,7 @@ > #ifndef DUMP_ARCH_H > #define DUMP_ARCH_H > > -typedef struct ArchDumpInfo { > +struct ArchDumpInfo { > int d_machine; /* Architecture */ > int d_endian; /* ELFDATA2LSB or ELFDATA2MSB */ > int d_class; /* ELFCLASS32 or ELFCLASS64 */ > @@ -25,7 +25,7 @@ typedef struct ArchDumpInfo { > uint64_t (*arch_sections_write_hdr_fn)(DumpState *s, uint8_t *buff); > int (*arch_sections_write_fn)(DumpState *s, uint8_t *buff); > void (*arch_cleanup_fn)(DumpState *s); > -} ArchDumpInfo; > +}; >
done > struct GuestPhysBlockList; /* memory_mapping.h */ > int cpu_get_dump_info(ArchDumpInfo *info, > --- > > With that: > Reviewed-by: Philippe Mathieu-Daudé <[email protected]> >
