On Wed, Oct 21, 2026 at 10:16 AM Richard Henderson
<[email protected]> wrote:
>
> This eliminates the majority of the code duplication between
> the _i32 and _i64 expanders. What remains are those expanders
> that truly differ between the two widths, or that are only
> present for one width.
>
> Changes for v6:
> - No __attribute__((alias)), since unsupported on MacOS.
> - Constants canonicalized in tcg_constant_internal, as pointed out in
> review.
> - Other flubs fixed, also per review.
I pointed out a bunch of trivial issues. checkpatch.pl also complains
about a things like
ERROR: storage class should be at the beginning of the declaration
#50: FILE: tcg/tcg-internal.h:63:
+QEMU_RET_ARG_NONNULL static inline TCGv_i64 TCGV128_LOW(TCGv_i128 t)
and
ERROR: space required after that ',' (ctx:VxV)
#123: FILE: tcg/tcg-op.c:322:
+ { tcg_gen_##NAME(TYPE, glue(C_,T1)(a), glue(C_,T2)(b), glue(C_,T3)(c)); }
Otherwise, this looks good to me. The whole series is.
Reviewed-by: Matt Turner <[email protected]>
