Christian Borntraeger <[email protected]> writes: > Am 19.10.26 um 21:27 schrieb Alex Bennée: >> As with x86_64 we now have the bits to add a KVM gdb test. A couple of >> minor wrinkles need to be handled. >> The first is applying an offset when loading the symbols to take >> into >> account the relocation that happens. >> The other minor wrinkle is the s390x only supports WP_WRITE watch >> points so we skip the other watch point tests lest we get confusing >> messages about failing to insert HW breakpoints. >> Signed-off-by: Alex Bennée <[email protected]> >> Reviewed-by: Marc-André Lureau <[email protected]> > > > Hi Alex, > > on an s390x KVM host, test_s390_kvm_gdb fails on current master > before gdb is even started: > > Traceback (most recent call last): > File "/root/REPOS/qemu/tests/functional/s390x/test_tuxrun.py", line 53, in > test_s390_kvm_gdb > self.common_tuxrun_gdb(kernel_asset=self.ASSET_S390X_KERNEL, > ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > vmlinux_asset=self.ASSET_S390X_VMLINUX, > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > ...<3 lines>... > haltmsg="Requesting system halt", > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > accel="kvm") > ^^^^^^^^^^^^ > TypeError: TuxRunBaselineTest.common_tuxrun_gdb() got an unexpected keyword > argument 'haltmsg' > > not ok 3 test_tuxrun.TuxRunS390xTest.test_s390_kvm_gdb > > haltmsg was removed after review, but not from this patch.
doh will fix. > > > > In any case, zhank you for enabling s390 gdb testing, -- Alex Bennée Virtualisation Tech Lead @ Linaro
