Reviewed-by: Kostiantyn Kostiuk <[email protected]> On Tue, Oct 27, 2026 at 1:08 PM Daniel P. Berrangé <[email protected]> wrote:
> On Mon, Oct 26, 2026 at 08:03:52PM +0100, Roman Bogorodskiy wrote: > > Implement 'guest-network-get-route' for FreeBSD. This > > implementation uses the sysctl(3) interface to get > > the routing table. > > > > Limitations: > > > > - This implementation does not populate irtt, refcnt, use, > > window, source, and srcprefixlen fields. > > - The implementation uses the default FIB (routing table) 0. > > Selecting QGA's active FIB is left for the follow-up patch. > > > > While here, spell Windows correctly in @GuestNetworkRoute documentation > > in qapi-schema.json. > > > > Signed-off-by: Roman Bogorodskiy <[email protected]> > > Acked-by: Markus Armbruster <[email protected]> > > --- > > Changes since v1: > > > > - qga/qapi-schema.json spelling: windows -> Windows, freebsd -> FreeBSD > > in the "@GuestNetworkRoute" documentation. > > - meson.build: check that the 'struct rt_metrics' has 'rmx_metric' > > member which is available only on FreeBSD 16. > > > > Changes since v2: > > > > - If interface name cannot be obtained, default it to "if<index>" > > instead of "?", similarly to the Windows implementation. > > - Use getnameinfo() for both AF_INET and AF_INET6 formatting. > > > > meson.build | 6 ++ > > qga/commands-bsd.c | 173 +++++++++++++++++++++++++++++++++++++++++++ > > qga/qapi-schema.json | 31 ++++---- > > 3 files changed, 195 insertions(+), 15 deletions(-) > > Reviewed-by: Daniel P. Berrangé <[email protected]> > > With regards, > Daniel > -- > |: https://berrange.com ~~ https://hachyderm.io/@berrange :| > |: https://libvirt.org ~~ https://entangle-photo.org :| > |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :| > >
