Re: [PATCH v4 15/18] hw/riscv/rv-trace-messages: add format 1 msgs with branch info

[Jay Chang]

>
> +size_t rv_etrace_gen_encoded_format1(uint8_t *buf,
> +                                     uint8_t branches, uint32_t
> branch_map,
> +                                     uint64_t addr,
> +                                     bool notify, bool updiscon)
> +{
> +    RVTraceMessageHeader header = {.flow = 0, .extend = 0};
> +    RVTraceFormat1Payload payload = {.format = 0b01,
> +                                     .branches = branches,
> +                                     .notify = notify,
> +                                     .updiscon = updiscon};
>
Should we also initialize .branch_map here with .branch_map = branch_map?
The function accepts branch_map, but it is not included in this payload
initializer.

Thanks
Jay Chang