On 10/28/26 11:40, Matt Turner wrote:
On Wed, Oct 28, 2026 at 12:32 PM Richard Henderson <[email protected]> wrote:+ if (sh == 0) { + tcg_gen_add(type, dst, base, index); + } else if (TCG_TARGET_lea_sh_valid(TCG_TYPE_I32, sh)) {Shouldn't this be "type" rather than TCG_TYPE_I32? As written, riscv64 never emits lea: its TCG_TARGET_lea_sh_valid requires type == TCG_TYPE_REG, so for I64 we always fall back to shli+add and patch 15 is dead code. On aarch64 it also rejects I64 shifts of 32..63.
Arg. I fixed 3 of 4 instances the last time around... Thanks. r~
