On 10/28/2026 12:15 PM, Yonggang Luo wrote: > scsi-hd and scsi-cd added the s390x loadparm property from class_init > when target_s390x() was true. Register a second type for each name > that always adds loadparm, and select the two with target_s390x() and > target_not_s390x(). > > Signed-off-by: Yonggang Luo <[email protected]> > --- > hw/scsi/scsi-disk.c | 43 +++++++++++++++++++++++++++++++++---------- > 1 file changed, 33 insertions(+), 10 deletions(-) >
Looks good to me overall, let's just keep the !s390 as a local callback here. Regards, Pierrick
