On Thursday, October 29, 2026, Pierrick Bouvier < [email protected]> wrote:
> On 10/28/2026 12:15 PM, Yonggang Luo wrote: > > virtio-blk-pci and virtio-net-pci added the s390x loadparm property > > from class_init when target_s390x() was true. Register each > > VirtioPCIDeviceTypeInfo twice. The s390x variant calls > > pci_qdev_property_add_specifics(), which now always adds loadparm, > > and the other variant does not. target_s390x() and target_not_s390x() > select > > the two. > > > > Signed-off-by: Yonggang Luo <[email protected]> > > --- > > hw/pci/pci.c | 13 +++++-------- > > hw/virtio/virtio-blk-pci.c | 22 +++++++++++++++++++++- > > hw/virtio/virtio-net-pci.c | 22 +++++++++++++++++++++- > > 3 files changed, 47 insertions(+), 10 deletions(-) > > > > target_not_s390x will be duplicated at many place, is that fine? Fine for me, let's see what virtio maintainers think about it. > > Regards, > Pierrick > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo
