Hi Gerd, > Subject: Re: [PATCH v6 1/8] hw/usb/bus: Let a bus opt out of automatic hub > insertion > > Hi, > > > > Alternative idea would be to add the config option, but only enable > > > the automatic hub logic for actual usb 1.1 controllers (ohci / > > > uhci), where it does not matter much for devices whenever they are > > > plugged into an root port or hub port. > > > > Sorry for the late reply. > > > > Yes, it gets in the way. usbredir carries one device per connection, > > so our bus has one port. Plugging that device in adds a hub, and the > > device ends up behind it. That is why I added the flag. > > > > If you would rather do one of these, tell me and I will send it: > > > > 1. Remove the automatic hub. > > 2. Keep it, but only for the USB 1.1 controllers, ohci and uhci. > > I think it is better to keep the logic for now and add an config option for > it. > This way we can tweak things easily if needed. Set the option to "no > automatic hub" for your controller and also ehci + xhci, best as separate > patch > for each controller. > > take care, > Gerd
Thanks for the suggestion. I sent v7 yesterday, before I read this. https://patchwork.kernel.org/project/qemu-devel/cover/[email protected]/ I will send v8 with your suggested after Marc-André Lureau and Junjie have commented. Thanks, Jamin
