On 10/29/26 10:20, Philippe Mathieu-Daudé wrote:
@@ -519,7 +519,9 @@ foreach target, plan: tcg_tests
          skip_test = 'gdb not available for ' + gdb_arch
        endif
+ test_protocol = 'protocol' in setup ? setup['protocol'] : 'exitcode'
        if skip_test != ''
+        test_protocol = 'exitcode'
          # still declare test, but skip it and print reason
          cmd = ['sh', '-c', 'echo "' + skip_test + '" && exit 77']
        endif

While this isn't wrong, is it less confusing to use else/elif than overwrite test_protocol?

Anyway,
Reviewed-by: Richard Henderson <[email protected]>

r~

Reply via email to