On Thu, Oct 29, 2026 at 03:14:32PM -0600, Mathieu Poirier wrote: > On Wed, Oct 28, 2026 at 01:51:29PM +0900, Kohei Enju wrote: > > On 10/26 19:06, Lorenzo Pieralisi wrote: > > > On Wed, Oct 21, 2026 at 11:42:14PM +1000, Gavin Shan wrote: > > > > On 10/20/26 6:46 AM, Mathieu Poirier wrote: > > > > > On Thu, Sep 24, 2026 at 12:12:35PM +0900, Kohei Enju wrote: > > > > > > On 09/22 10:01, Lorenzo Pieralisi wrote: > > > > > > > On Tue, Sep 15, 2026 at 04:27:21PM -0500, Michael Roth wrote: > > > > > > > > On Thu, Sep 03, 2026 at 01:35:50PM -0600, Mathieu Poirier wrote: > > > > > > > > > From: Jean-Philippe Brucker <[email protected]> > > > > > > > > > > > > > > > > > > Add a new RmeGuest object, inheriting from > > > > > > > > > ConfidentialGuestSupport, to > > > > > > > > > support the Arm Realm Management Extension (RME). It is > > > > > > > > > instantiated by > > > > > > > > > passing on the command-line: > > > > > > > > > > > > > > > > > > -M virt,confidential-guest-support=<id> > > > > > > > > > -object rme-guest,id=<id> > > > > > > > > > > > > > > > > > > This is only the skeleton. Support will be added in following > > > > > > > > > patches. > > > > > > > > > > > > > > > > > > Signed-off-by: Jean-Philippe Brucker > > > > > > > > > <[email protected]> > > > > > > > > > Signed-off-by: Mathieu Poirier <[email protected]> > > > > > > > > > --- > > > > > > > > > docs/system/confidential-guest-support.rst | 1 + > > > > > > > > > qapi/qom.json | 13 +++++++ > > > > > > > > > target/arm/kvm-rme.c | 42 > > > > > > > > > ++++++++++++++++++++++ > > > > > > > > > target/arm/meson.build | 5 ++- > > > > > > > > > 4 files changed, 60 insertions(+), 1 deletion(-) > > > > > > > > > create mode 100644 target/arm/kvm-rme.c > > > > > > > > > > > > > > > > > > diff --git a/docs/system/confidential-guest-support.rst > > > > > > > > > b/docs/system/confidential-guest-support.rst > > > > > > > > > index 562a7c3c2852..abb56923ad13 100644 > > > > > > > > > --- a/docs/system/confidential-guest-support.rst > > > > > > > > > +++ b/docs/system/confidential-guest-support.rst > > > > > > > > > @@ -42,5 +42,6 @@ Currently supported confidential guest > > > > > > > > > mechanisms are: > > > > > > > > > * POWER Protected Execution Facility (PEF) (see > > > > > > > > > :ref:`power-papr-protected-execution-facility-pef`) > > > > > > > > > * s390x Protected Virtualization (PV) (see > > > > > > > > > :doc:`s390x/protvirt`) > > > > > > > > > * AWS Nitro Enclaves (see :doc:`nitro`) > > > > > > > > > +* Arm Realm Management Extension (RME) > > > > > > > > > Other mechanisms may be supported in future. > > > > > > > > > diff --git a/qapi/qom.json b/qapi/qom.json > > > > > > > > > index 776b13027fd8..52997c29a32d 100644 > > > > > > > > > --- a/qapi/qom.json > > > > > > > > > +++ b/qapi/qom.json > > > > > > > > > @@ -1288,6 +1288,17 @@ > > > > > > > > > 'data': { '*pretty': 'bool', > > > > > > > > > '*close-action': 'MonitorQMPCloseAction' } } > > > > > > > > > +## > > > > > > > > > +# @RmeGuestProperties: > > > > > > > > > +# > > > > > > > > > +# Properties for rme-guest objects. > > > > > > > > > +# > > > > > > > > > +# Since: 11.1 > > > > > > > > > +## > > > > > > > > > +{ 'struct': 'RmeGuestProperties', > > > > > > > > > + 'base': 'ConfidentialGuestSupportProperties', > > > > > > > > > > > > > > > > Just FYI, based on input from Markus I'm planning to drop this > > > > > > > > ConfidentialGuestSupportProperties base type from my series > > > > > > > > since it's probably only SNP/TDX that need to be able to switch > > > > > > > > it on/off, whereas this series appears to use/require it from > > > > > > > > the start. > > > > > > > > > > > > > > > > I'm not exactly sure what it will look like for v3 yet, but if > > > > > > > > you > > > > > > > > were based on v2 you'd instead probably just do the following > > > > > > > > in the > > > > > > > > instance_init function for your rme-guest instance: > > > > > > > > > > > > > > > > cgs->allow_convert_in_place = true; > > > > > > > > cgs->convert_in_place = true; > > > > > > > > > > > > > > > > rather than exposing it as a cmdline option. > > > > > > > > > > > > > > Yep, it won't be an option for CCA Realms anyway since that will > > > > > > > be > > > > > > > the baseline. > > > > > > > > > > > > IIUC, in-place conversion requires RAM backed by a shared/mappable > > > > > > guest_memfd. If in-place conversion is always enabled for CCA > > > > > > Realms, > > > > > > could QEMU also select the equivalent of > > > > > > > > > > > > -object memory-backend-guest-memfd,id=ram0,size=...,share=on > > > > > > > > > > > > automatically for the default RAM, so that specifying the RAM size > > > > > > with > > > > > > `-m` is sufficient? > > > > > > > > > > Are you suggesting that on Arm, we completely get rid of > > > > > > > > > > -object > > > > > memory-backend-guest-memfd,id=ram0,size=$(RAMSIZE),share=on > > > > > > > > > > or simply to get rid of "size=$(RAMSIZE)" in the above because it is > > > > > redundant > > > > > with "-m $(RAMSIZE)"? > > > > > > > > > > Gavin and Michael, what is your take on that suggestion? > > > > > > > > > > > > > I don't think that's what Kohei meant. He actually suggested the memory > > > > backend > > > > shall be pinned to memory-backend-guest-memfd and its in-place > > > > conversion shall > > > > be enabled when the memory backend isn't explicitly specified by users > > > > through > > > > "-object memory-backend-xxxx". For this inexplicit case, where the > > > > memory backend > > > > is determined by '-mem-path', the memory backend is either > > > > TYPE_MEMORY_BACKEND_FILE > > > > or TYPE_MEMORY_BACKEND_RAM. Please refer to create_default_memdev(). > > > > > > > > I think Kohei's suggestion makes sense. Besides, I think '-mem-path' > > > > should be > > > > disallowed for CCA Realms as TYPE_MEMORY_BACKEND_FILE isn't what we > > > > want. > > > > > > Kohei, what were you suggesting then please ? I think > > > TYPE_MEMORY_BACKEND_FILE > > > would not pass the checks required by Michael's v3 [0] on CCA - I will > > > test this > > > and report back but the only backend allowed, rightly, is memfd,share=on, > > > so it > > > _is_ disallowed. > > > > Sorry for the late response. > > > > To clarify, I meant the latter: when rme-guest is selected and the user > > has not explicitly provided a memory backend, QEMU could automatically > > create the default RAM as a shared guest-memfd backend. > > > > In other words, rather than only rejecting the default file/RAM backend, > > the Realm configuration could select the equivalent of > > > > -object > > memory-backend-guest-memfd,id=<default-ram-id>,size=<RAMSIZE>,share=on > > > > by default. Explicitly specified memory backends would still need to be > > validated against the Realm requirements. > > > > My intention was that, if in-place conversion is the baseline for CCA > > Realms, `-m <size>` should be sufficient for the common Realm case, > > while preserving an explicit memory-backend option for users who need to > > control it. > > Many thanks for the clarification, it is very helpful. I will look into > implementing something along those lines for V6 and we can reconsider how to > move forward at that time.
And then I read Michael's comment again, and again and again... > > Thanks, > Mathieu > > > > > That said, I do not have a strong preference for deciding the default > > `-m` behavior at this stage. If it is premature to make that decision > > before the memory-backend and conversion interfaces have settled, I am > > happy to keep the explicit guest-memfd backend requirement for now and > > revisit the default behavior later. > > For the time being I will hold back on moving forward with this request. Let's revisit at some point in the future. > > Thanks, > > Kohei > > > > > > > > Lorenzo > > > > > > [0] > > > https://lore.kernel.org/kvm/[email protected]/ > > > > > > > Thanks, > > > > Gavin > > > > > > > > > Thanks, > > > > > Mathieu > > > > > > > > > > > > > > > > > Thanks, > > > > > > Kohei > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > Lorenzo > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > Mike > > > > > > > > > > > > > > > > > + 'data': {} } > > > > > > > > > + > > > > > > > > > ## > > > > > > > > > # @ObjectType: > > > > > > > > > # > > > > > > > > > @@ -1346,6 +1357,7 @@ > > > > > > > > > { 'name': 'pr-manager-helper', > > > > > > > > > 'if': 'CONFIG_LINUX' }, > > > > > > > > > 'qtest', > > > > > > > > > + 'rme-guest', > > > > > > > > > 'rng-builtin', > > > > > > > > > 'rng-egd', > > > > > > > > > { 'name': 'rng-random', > > > > > > > > > @@ -1427,6 +1439,7 @@ > > > > > > > > > 'pr-manager-helper': { 'type': > > > > > > > > > 'PrManagerHelperProperties', > > > > > > > > > 'if': 'CONFIG_LINUX' > > > > > > > > > }, > > > > > > > > > 'qtest': 'QtestProperties', > > > > > > > > > + 'rme-guest': 'RmeGuestProperties', > > > > > > > > > 'rng-builtin': 'RngProperties', > > > > > > > > > 'rng-egd': 'RngEgdProperties', > > > > > > > > > 'rng-random': { 'type': > > > > > > > > > 'RngRandomProperties', > > > > > > > > > diff --git a/target/arm/kvm-rme.c b/target/arm/kvm-rme.c > > > > > > > > > new file mode 100644 > > > > > > > > > index 000000000000..42e1d1e7b859 > > > > > > > > > --- /dev/null > > > > > > > > > +++ b/target/arm/kvm-rme.c > > > > > > > > > @@ -0,0 +1,42 @@ > > > > > > > > > +/* > > > > > > > > > + * QEMU Arm RME support > > > > > > > > > + * > > > > > > > > > + * SPDX-License-Identifier: GPL-2.0-or-later > > > > > > > > > + * > > > > > > > > > + * Copyright Linaro 2026 > > > > > > > > > + */ > > > > > > > > > + > > > > > > > > > +#include "qemu/osdep.h" > > > > > > > > > + > > > > > > > > > +#include "hw/core/boards.h" > > > > > > > > > +#include "hw/core/cpu.h" > > > > > > > > > +#include "kvm_arm.h" > > > > > > > > > +#include "migration/blocker.h" > > > > > > > > > +#include "qapi/error.h" > > > > > > > > > +#include "qom/object_interfaces.h" > > > > > > > > > +#include "system/confidential-guest-support.h" > > > > > > > > > +#include "system/kvm.h" > > > > > > > > > +#include "system/runstate.h" > > > > > > > > > + > > > > > > > > > +#define TYPE_RME_GUEST "rme-guest" > > > > > > > > > +OBJECT_DECLARE_SIMPLE_TYPE(RmeGuest, RME_GUEST) > > > > > > > > > + > > > > > > > > > +struct RmeGuest { > > > > > > > > > + ConfidentialGuestSupport parent_obj; > > > > > > > > > +}; > > > > > > > > > + > > > > > > > > > +OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES(RmeGuest, > > > > > > > > > rme_guest, RME_GUEST, > > > > > > > > > + > > > > > > > > > CONFIDENTIAL_GUEST_SUPPORT, > > > > > > > > > + { > > > > > > > > > TYPE_USER_CREATABLE }, { }) > > > > > > > > > + > > > > > > > > > +static void rme_guest_class_init(ObjectClass *oc, const void > > > > > > > > > *data) > > > > > > > > > +{ > > > > > > > > > +} > > > > > > > > > + > > > > > > > > > +static void rme_guest_init(Object *obj) > > > > > > > > > +{ > > > > > > > > > +} > > > > > > > > > + > > > > > > > > > +static void rme_guest_finalize(Object *obj) > > > > > > > > > +{ > > > > > > > > > +} > > > > > > > > > diff --git a/target/arm/meson.build b/target/arm/meson.build > > > > > > > > > index 0369f96b4cc6..9d322a7aad28 100644 > > > > > > > > > --- a/target/arm/meson.build > > > > > > > > > +++ b/target/arm/meson.build > > > > > > > > > @@ -31,7 +31,10 @@ arm_common_user_system_ss.add(when: > > > > > > > > > 'TARGET_AARCH64', if_true: files( > > > > > > > > > arm_common_system_ss.add(files( > > > > > > > > > 'arm-qmp-cmds.c', > > > > > > > > > )) > > > > > > > > > -arm_system_ss.add(when: 'CONFIG_KVM', if_true: > > > > > > > > > files('hyp_gdbstub.c', 'kvm.c')) > > > > > > > > > +arm_system_ss.add(when: 'CONFIG_KVM', if_true: files( > > > > > > > > > + 'hyp_gdbstub.c', > > > > > > > > > + 'kvm.c', > > > > > > > > > + 'kvm-rme.c')) > > > > > > > > > arm_system_ss.add(when: 'CONFIG_HVF', if_true: > > > > > > > > > files('hyp_gdbstub.c')) > > > > > > > > > arm_user_ss.add(files('cpu.c')) > > > > > > > > > -- > > > > > > > > > 2.43.0 > > > > > > > > > > > > > > > > > > > > > > > > > > >
