On Thu, 2026-10-29 at 12:58 +0000, Daniel P. Berrangé wrote: > On Thu, Oct 29, 2026 at 09:32:12AM +1000, Alistair wrote: > > Hey, > > > > Sashiko just merged initial support for QEMU [1]. > > snip > > > So, now that Sashiko also supports QEMU there are two exciting use > > cases: > > > > 1. Developers can run it locally to review their patches before > > sending > > them to the list. This can catch issues before sending patches > > > > 2. Maintainers can run an instance to review patches. How you set > > this > > up depends on the maintainer and how many tokens you have. Pointing > > it > > at the list directly and running it for all patches might be too > > much, > > but some combination of manually triggering it for certain patches > > seems to work well. The Settings.toml file can be setup based on > > what > > you want to do. > > > > The hope with this is to save maintainers time as Sashiko can catch > > issues without requiring much time from a maintainer. > > > > QEMU support in Sashiko is very new, so it will take some tweaking > > to > > improve things, but it is at least a good starting place. > > > > 1: > > https://github.com/sashiko-dev/sashiko/commit/e432036bba7ab10d4517385916e6c834d8176f70 > > This has added a large set of documents about QEMU's internals to a > 3rd party repository. Is there not a way to have Sashiko acquire > all the review policies from qemu.git directly ?
Sashiko has access to the QEMU tree. Otherwise Sashiko won't go out onto the internet and access things. So in theory we can point it at docs or anything else in the QEMU repo. > > IMHO, the QEMU project/maintauners really ought to own & update > review > guidelines directly in our repo, especially as we're already > intending > to add lots of relevant information to qemu.git for AI usage in > general. That should generally be workable, if we have those guidelines Alistair > > > With regards, > Daniel
