Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

[Orit Wasserman]

On 08/02/2012 05:01 PM, Eric Blake wrote:
> On 08/02/2012 06:44 AM, Orit Wasserman wrote:
>> Signed-off-by: Benoit Hudzia <benoit.hud...@sap.com>
>> Signed-off-by: Petter Svard <pett...@cs.umu.se>
>> Signed-off-by: Aidan Shribman <aidan.shrib...@sap.com>
>> Signed-off-by: Orit Wasserman <owass...@redhat.com>
>> Signed-off-by: Juan Quintela <quint...@redhat.com>
>> ---
> 
> 
>>  
>> +6. Migration is being performed and XBZRLE is active:
>> +
>> +-> { "execute": "query-migrate" }
>> +<- {
>> +      "return":{
>> +         "status":"active",
>> +         "capabilities" : [ { "capability": "xbzrle", "state" : true } ],
>> +         "ram":{
>> +            "total":1057024,
>> +            "remaining":1053304,
>> +            "transferred":3720,
>> +            "duplicate": 10,
>> +            "normal": 3333
>> +         },
>> +         "xbzrle-cache":{
>> +            "cache-size": 1024,
> 
> Is this value in bytes?  It should be.  Which means that this example is
> bogus - 1024 is smaller than one page, but your caching code rounded to
> page boundaries.  Sounds like you forgot a scaling factor somewhere.
> Also, s/: /:/
> 
will be fixed,
Thanks,
Orit