The QMP Reference Manual describes NumaOptions and NumaNodeOptions as "(for OptsVisitor)". This makes no sense; the OptsVisitor is a purely internal thing.
When commit 0042109a6a (NUMA: convert -numa option to use OptsVisitor) added these QAPI types, both "(for OptsVisitor)" were correct and merely schema comments. They have since become wrong (both types are part of QMP according to query-qmp-schema) and reference documentation. Delete both instances. Signed-off-by: Markus Armbruster <[email protected]> Message-ID: <[email protected]> Reviewed-by: Daniel P. Berrangé <[email protected]> [Straightforward conflict with commit 74c1a2e9a3 (qapi: convert simple data struct intros for machine.json) and commit c4d2c31e05 (qapi: convert remaining simple intros for machine.json) resolved] --- qapi/machine.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/machine.json b/qapi/machine.json index 9b145c635b..9dc63c1c8b 100644 --- a/qapi/machine.json +++ b/qapi/machine.json @@ -455,7 +455,7 @@ ## # @NumaOptions: -# A discriminated record of NUMA options. (for OptsVisitor) +# A discriminated record of NUMA options. # # @type: NUMA option type # @@ -473,7 +473,7 @@ ## # @NumaNodeOptions: -# Create a guest NUMA node. (for OptsVisitor) +# Create a guest NUMA node. # # @nodeid: NUMA node ID (increase by 1 from 0 if omitted) # -- 2.55.0
