Daniel P. BerrangĂ© <[email protected]> writes:

> On Mon, Nov 02, 2026 at 03:56:27PM +0100, Markus Armbruster wrote:
>> docs/devel/qapi-code-gen.rst documents "Since: x.y.z" and "(since
>> x.y.z)", but we almost always use just x.y.  Adjust the doc and the
>> exceptions to the ruling practice.
>
> Shortening to 2 digits is sensible given our current version
> numbering scheme. The 3rd digit is exclusively for stable
> branches that should not be forking qapi schemas.
>
> This only applies since our switch to this versioning scheme,
> which was in 3.0.0, so anything earlier than this should not
> be changed IMHO.

Makes sense.

>> Signed-off-by: Markus Armbruster <[email protected]>
>> ---
>>  docs/devel/qapi-code-gen.rst |  4 ++--
>>  docs/interop/firmware.json   |  4 ++--
>>  qapi/accelerator.json        |  6 +++---
>>  qapi/crypto.json             |  2 +-
>>  qga/qapi-schema.json         | 38 ++++++++++++++++++------------------
>>  5 files changed, 27 insertions(+), 27 deletions(-)
>> 
>
>> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
>> index 7b937713e6..531fb8f8e0 100644
>> --- a/qga/qapi-schema.json
>> +++ b/qga/qapi-schema.json
>> @@ -110,7 +110,7 @@
>>  #
>>  # Returns: The unique integer id passed in by the client
>>  #
>> -# Since: 0.15.0
>> +# Since: 0.15
>>  ##
>>  { 'command': 'guest-sync',
>>    'data':    { 'id': 'int' },

[...]

>> @@ -464,7 +464,7 @@
>>  #    filesystems were unfrozen before this call, and that the
>>  #    filesystem state may have changed before issuing this command.
>>  #
>> -# Since: 0.15.0
>> +# Since: 0.15
>>  ##
>>  { 'command': 'guest-fsfreeze-thaw',
>>    'returns': 'int',
>
> Don't change any of these, since at that vintage, the 3rd digit
> was significant.

Done in v2.

Thank you!


Reply via email to