On Mon, 2 Nov 2026 at 10:42, Lorand Marton <[email protected]> wrote: > > Based-on: <[email protected]> > > Two fixes for the BCM2838 GENET model of "[PATCH v6 00/17] > hw/arm/raspi4b: working PCIe and GENET (real networking)", which is in > target-arm.next. They apply to target-arm.next; if that is simpler, > they can also be folded into patch 12/17 (implement GENET TX path) and > patch 13/17 (implement GENET RX path) of that series. > > - The TX consumer index counted past 16 bits, so the first transmit > across the wrap never ended: the device sent the ring's descriptors > forever with the BQL held, and the guest and the monitor hung. A > guest sending a sustained stream hung after about 65k descriptors. > - The RX path wrote frames past the consumer index of a full ring and > overwrote frames the guest had not read. The fix keeps them queued > in the net layer until the guest frees descriptors, as e1000 does; > real GENET drops them and counts them in DISCARD_CNT.
I'm just about to send a pullreq with the GENET changes in it, to hit the softfreeze deadline. I think what I'll do with these bugfix patches is put them in for the next lot after that, so we have some time for code review, rather than trying to apply them in a hurry and maybe merge them with the existing tx and rx patches. thanks -- PMM
