Replace sprintf() by safer snprintf() to avoid when using Apple clang 17.0.0 on macOS ARM64:
../tests/unit/test-visitor-serialization.c:1031:5: warning: 'sprintf' is deprecated [-Wdeprecated-declarations] ../tests/unit/test-visitor-serialization.c:1035:13: warning: 'sprintf' is deprecated [-Wdeprecated-declarations] ... Use pstrcpy() when no formatting is needed. Signed-off-by: Philippe Mathieu-Daudé <[email protected]> --- tests/unit/test-visitor-serialization.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/tests/unit/test-visitor-serialization.c b/tests/unit/test-visitor-serialization.c index 2d365999fc82..254c24d5cda4 100644 --- a/tests/unit/test-visitor-serialization.c +++ b/tests/unit/test-visitor-serialization.c @@ -14,6 +14,7 @@ #include "qemu/osdep.h" #include <float.h> +#include "qemu/cutils.h" #include "test-qapi-visit.h" #include "qapi/error.h" #include "qobject/qjson.h" @@ -1028,12 +1029,13 @@ static void add_visitor_type(const SerializeOps *ops) TestArgs *args; int i = 0; - sprintf(testname_prefix, "/visitor/serialization/%s", ops->type); + snprintf(testname_prefix, sizeof(testname_prefix), + "/visitor/serialization/%s", ops->type); if (ops->caps & VCAP_PRIMITIVES) { while (pt_values[i].type != PTYPE_EOL) { - sprintf(testname, "%s/primitives/%s", testname_prefix, - pt_values[i].description); + snprintf(testname, sizeof(testname), "%s/primitives/%s", + testname_prefix, pt_values[i].description); args = g_malloc0(sizeof(*args)); args->ops = ops; args->test_data = &pt_values[i]; @@ -1043,13 +1045,15 @@ static void add_visitor_type(const SerializeOps *ops) } if (ops->caps & VCAP_STRUCTURES) { - sprintf(testname, "%s/struct", testname_prefix); + pstrcpy(testname, sizeof(testname), testname_prefix); + pstrcat(testname, sizeof(testname), "/struct"); args = g_malloc0(sizeof(*args)); args->ops = ops; args->test_data = NULL; g_test_add_data_func(testname, args, test_struct); - sprintf(testname, "%s/nested_struct", testname_prefix); + pstrcpy(testname, sizeof(testname), testname_prefix); + pstrcat(testname, sizeof(testname), "/nested_struct"); args = g_malloc0(sizeof(*args)); args->ops = ops; args->test_data = NULL; @@ -1057,7 +1061,8 @@ static void add_visitor_type(const SerializeOps *ops) } if (ops->caps & VCAP_LISTS) { - sprintf(testname, "%s/nested_struct_list", testname_prefix); + pstrcpy(testname, sizeof(testname), testname_prefix); + pstrcat(testname, sizeof(testname), "/nested_struct_list"); args = g_malloc0(sizeof(*args)); args->ops = ops; args->test_data = NULL; @@ -1067,8 +1072,8 @@ static void add_visitor_type(const SerializeOps *ops) if (ops->caps & VCAP_PRIMITIVE_LISTS) { i = 0; while (pt_values[i].type != PTYPE_EOL) { - sprintf(testname, "%s/primitive_list/%s", testname_prefix, - pt_values[i].description); + snprintf(testname, sizeof(testname), "%s/primitive_list/%s", + testname_prefix, pt_values[i].description); args = g_malloc0(sizeof(*args)); args->ops = ops; args->test_data = &pt_values[i]; -- 2.55.0
