Hi, On Sun, 23 Sep 2007, Ivan Kalvachev wrote:
> I've been having problems using vvfat virtual block device. Even linux > fdisk was able to find problems with it. The reason turned out to be > simple, MBR have bogus parameters. Thanks for doing this; I did not find any time for that. Overall, I like what you did, but here are some comments (if you would have inlined the patch, I would have commented with references): - I like the convert_sector2CHS() function, although I would have named it sector2CHS() for brevity (although the pretty magic -- or unintuitive -- detection if lba is needed would have to be done differently, which I maintain would be better), - you write the NT-ID byte-per-byte, whereas I would have used strcpy() for clarity, - I'd have introduced a member nt_id instead of hardcoding an offset into the "ignored" part, and - fat_type == 12 and lba does not make sense, or does it? Thanks, Dscho
