On 11/6/2026 9:06 AM, Peter Maydell wrote: > On Fri, 6 Nov 2026 at 16:59, Pierrick Bouvier > <[email protected]> wrote: >> >> On 11/6/2026 7:58 AM, Peter Maydell wrote: >>> This reverts commit ab78ac76f44a1241e76fd32d248df62d83f1ea58. >>> >>> The change to create the version header in meson.build loses >>> the dependency needed for the header file to be built when >>> it doesn't exist. This means that: >>> >>> * if you delete the build/qemu-version.h file, an incremental >>> rebuild fails, rather than recreating it >> >> That's not what I observe. From current master, file is correctly >> recreated. Do you still observe a problem with a clean build folder? > > Yes. > > $ git log --oneline -1 > f71afb409a8 Merge tag 'pull-loongarch-20261105' of > https://github.com/bibo-mao/qemu into staging > $ rm -rf build/arm && mkdir build/arm && (cd build/arm && > '../../configure' > '--target-list=arm-softmmu,aarch64-softmmu,arm-linux-user,aarch64-linux-user,aarch64_be-linux-user' > '--cc=ccache gcc' '--with-pkgversion=pm215' '--enable-debug' > '--enable-docs') && make -C build/arm -j20 > [...] > $ make -C build/arm -j20 > make: Entering directory '/home/pm215/qemu/build/arm' > [1/35] Generating tests/include/QAPI test (include) with a custom command > make: Leaving directory '/home/pm215/qemu/build/arm' > $ make -C build/arm -j20 > make: Entering directory '/home/pm215/qemu/build/arm' > [1/27] Compiling C object qga/qemu-ga.p/main.c.o > FAILED: qga/qemu-ga.p/main.c.o > /usr/bin/ccache gcc -m64 -Iqga/qemu-ga.p -Iqga -I../../qga -I. -Iqapi > -Itrace -Iui -Iui/shader -I/usr/include/glib-2.0 > -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fdiagnostics-color=auto > -Wall -Winvalid-pch -Werror -std=gnu11 -O0 -g -mcx16 -msse2 > -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE > -fno-strict-aliasing -fno-common -fwrapv -ftrivial-auto-var-init=zero > -fzero-call-used-regs=used-gpr -fstack-protector-strong -Wempty-body > -Wendif-labels -Wexpansion-to-defined -Wformat-overflow=2 > -Wformat-security -Wformat-y2k -Wignored-qualifiers > -Wimplicit-fallthrough=2 -Winit-self -Wmissing-format-attribute > -Wmissing-prototypes -Wnested-externs -Wold-style-declaration > -Wold-style-definition -Wredundant-decls -Wshadow=local > -Wstrict-prototypes -Wtype-limits -Wundef -Wvla -Wwrite-strings > -Wno-missing-include-dirs -Wno-psabi -Wno-shift-negative-value > -isystem /home/pm215/qemu/linux-headers -isystem linux-headers -iquote > . -iquote /home/pm215/qemu -iquote /home/pm215/qemu/include -iquote > /home/pm215/qemu/host/include/x86_64 -iquote > /home/pm215/qemu/host/include/generic -iquote > /home/pm215/qemu/tcg/x86_64 -pthread -fPIE -MD -MQ > qga/qemu-ga.p/main.c.o -MF qga/qemu-ga.p/main.c.o.d -o > qga/qemu-ga.p/main.c.o -c ../../qga/main.c > In file included from ../../qga/main.c:33: > /home/pm215/qemu/include/qemu/version.h:11:10: fatal error: > qemu-version.h: No such file or directory > 11 | #include "qemu-version.h" > | ^~~~~~~~~~~~~~~~ > compilation terminated. > [etc] > > I have run into this problem about a dozen times this week with > different build trees and different git branches, and it is very > annoying. > >> The problem seems to be crossing this commit, which we can't do anything >> about since it's there. > > Yeah, it's going to be a broken git bisect for that part of > history, which is unavoidable. But the current state of git > is (a) broken and (b) not clearly what we actually want, per > the other thread. > > -- PMM
I see, the missing bit I didn't use is '--with-pkgversion=pm215'. Without it, it works fine. Any reason you use it for dev builds? Seems to be something related to releases, which probably won't use incremental builds. Regards, Pierrick
