From: Peter Maydell <[email protected]> In vmdk_add_extent() we reject image files with an excessively large cluster_sectors parameter, but have no lower bound. In particular, if the cluster_sectors is 0 then we will set l1_entry_sectors also to 0, and later crash with a SIGFPE for division by zero.
Reject a zero cluster_sectors value, unless this is a flat extent (in which case cluster_sectors isn't relevant and the callsite always passes us zero). The worst case here is a self-denial-of-service with a QEMU crash, so this is a hardening bug. Cc: [email protected] Fixes: b3976d3c8b89 ("VMDK: introduce VmdkExtent") Reported-by: Tristan <https://gitlab.com/TristanInSec> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4017 Signed-off-by: Peter Maydell <[email protected]> Message-ID: <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]> --- block/vmdk.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/block/vmdk.c b/block/vmdk.c index bd18d32085f..d7e23ae8098 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -552,6 +552,11 @@ static int vmdk_add_extent(BlockDriverState *bs, BDRVVmdkState *s = bs->opaque; int64_t nb_sectors; + if (!flat && cluster_sectors == 0) { + error_setg(errp, "Invalid zero granularity, image may be corrupt"); + return -EINVAL; + } + if (cluster_sectors > 0x200000) { /* 0x200000 * 512Bytes = 1GB for one cluster is unrealistic */ error_setg(errp, "Invalid granularity, image may be corrupt"); -- 2.56.0
