On Mon, Nov 9, 2026 at 2:28 PM Daniel P. Berrangé <[email protected]> wrote: > > On Mon, Nov 09, 2026 at 01:36:05PM -0500, John Snow wrote: > > When auditing compilation, it is helpful to be able to see all of the > > object files passed during the linking step, which ninja can obscure > > behind temporary .rsp "response files". Normally, these are deleted > > immediately afterwards - but for debugging purposes, it is helpful to > > leave them behind to understand what went wrong. > > > > Signed-off-by: John Snow <[email protected]> > > --- > > Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Daniel P. Berrangé <[email protected]> >
Thanks! > > diff --git a/Makefile b/Makefile > > index 54547a37b1a..9dda1b3c89a 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -151,7 +151,7 @@ NINJAFLAGS = \ > > $(filter-out -j, \ > > $(or $(filter -l% -j%, $(MAKEFLAGS)), \ > > $(if $(filter --jobserver-auth=%, $(MAKEFLAGS)),, -j1))) \ > > - -d keepdepfile > > + -d keepdepfile $(if $(DEBUG),-d keeprsp) > > ninja-cmd-goals += $(or $(MAKECMDGOALS), all) > > ninja-cmd-goals += $(foreach g, $(MAKECMDGOALS), $(.ninja-goals.$g)) > > Alternatively we hardcode our makefile to raise meson's > annoyingly pessimistic defaults > > export MESON_RSP_THRESHOLD=126976 > > provided we detect we're not running a build inside Wine, or just > blindly assume no one is quite that crazy :-) I'll leave this to someone braver than me :') > > With regards, > Daniel > -- > |: https://berrange.com ~~ https://hachyderm.io/@berrange :| > |: https://libvirt.org ~~ https://entangle-photo.org :| > |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :| >
