On Thu, 2026-10-15 at 11:37 +0800, Jay Chang wrote:
> Spec: "If the AXI DMA Channel is halted (DMASR.Halted = 1 and
> DMACR.RS = 0), a write by the CPU to the TAILDESC_PTR register has
> no effect except to reposition the pause point."
> 
> Check DMASR.Halted and DMACR.RS in axidma_kick() so that a TAILDESC
> write while the channel is halted only updates the pointer and does
> not start a transfer.
> 
> Signed-off-by: Jay Chang <[email protected]>
> Reviewed-by: Frank Chang <[email protected]>
> Reviewed-by: Jim Shu <[email protected]>

Acked-by: Alistair Francis <[email protected]>

Alistair

> ---
>  hw/dma/xilinx_axidma.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c
> index 687b5080e0..a9c2c2a275 100644
> --- a/hw/dma/xilinx_axidma.c
> +++ b/hw/dma/xilinx_axidma.c
> @@ -536,6 +536,10 @@ static uint64_t axidma_read(void *opaque, hwaddr
> addr, unsigned size)
>  
>  static void axidma_kick(XilinxAXIDMA *d, struct Stream *s, int sid)
>  {
> +    if (stream_halted(s) && !stream_running(s)) {
> +        return;
> +    }
> +
>      s->regs[R_DMASR] &= ~DMASR_IDLE;
>      if (!sid) {
>          stream_process_mem2s(s, d->tx_data_dev, d->tx_control_dev);

Reply via email to