When HostMemoryBackend method alloc() fails, the error report isn't
always clear.  E.g. "-object memory-backend-shm,id=mem0,size=1E" fails
for me like this:

    qemu-system-x86_64: unable to map backing store for guest RAM: Cannot 
allocate memory

Leaves users guessing which part of the (often lengthy) command line
needs fixing.

Let's prepend a bit of context:

    qemu-system-x86_64: can't create memory-backend-shm: unable to map backing 
store for guest RAM: Cannot allocate memory

This makes an error message in shm_backend_memory_alloc() partly
redundant:

    qemu-system-x86_64: can't create memory-backend-shm: can't create shm 
backend with `share=off`

Change it to

    qemu-system-x86_64: can't create memory-backend-shm: backend requires 
'share=on'

Signed-off-by: Markus Armbruster <[email protected]>
---
 backends/hostmem-shm.c | 2 +-
 backends/hostmem.c     | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/backends/hostmem-shm.c b/backends/hostmem-shm.c
index 0a01c760551..d1cba22cbeb 100644
--- a/backends/hostmem-shm.c
+++ b/backends/hostmem-shm.c
@@ -31,7 +31,7 @@ shm_backend_memory_alloc(HostMemoryBackend *backend, Error 
**errp)
     int fd = cpr_find_fd(backend_name, 0);
 
     if (!backend->share) {
-        error_setg(errp, "can't create shm backend with `share=off`");
+        error_setg(errp, "backend requires 'share=on'");
         return false;
     }
 
diff --git a/backends/hostmem.c b/backends/hostmem.c
index 173d042be35..1c2a5d42fc5 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -335,6 +335,7 @@ size_t host_memory_backend_pagesize(HostMemoryBackend 
*memdev)
 static void
 host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)
 {
+    ERRP_GUARD();
     HostMemoryBackend *backend = MEMORY_BACKEND(uc);
     HostMemoryBackendClass *bc = MEMORY_BACKEND_GET_CLASS(uc);
     void *ptr;
@@ -346,6 +347,8 @@ host_memory_backend_memory_complete(UserCreatable *uc, 
Error **errp)
         return;
     }
     if (!bc->alloc(backend, errp)) {
+        error_prepend(errp, "can't create '%s': ",
+                      object_get_typename(OBJECT(uc)));
         return;
     }
 
-- 
2.55.0


Reply via email to