On 11/11/2026 12:23, Markus Armbruster wrote:
Property "size" is mandatory, and its setter
host_memory_backend_set_size() rejects value zero. Delete the
redundant checks for zero in the .alloc() callbacks.
Signed-off-by: Markus Armbruster <[email protected]>
---
backends/hostmem-epc.c | 5 -----
backends/hostmem-file.c | 4 ----
backends/hostmem-memfd.c | 5 -----
backends/hostmem-ram.c | 5 -----
backends/hostmem-shm.c | 5 -----
5 files changed, 24 deletions(-)
diff --git a/backends/hostmem-epc.c b/backends/hostmem-epc.c
index ab20b182331..e1c784249ff 100644
--- a/backends/hostmem-epc.c
+++ b/backends/hostmem-epc.c
@@ -24,11 +24,6 @@ sgx_epc_backend_memory_alloc(HostMemoryBackend *backend,
Error **errp)
uint32_t ram_flags;
int fd;
- if (!backend->size) {
- error_setg(errp, "can't create backend with size 0");
- return false;
- }
-
fd = qemu_open("/dev/sgx_vepc", O_RDWR, errp);
if (fd < 0) {
return false;
diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
index 6ad9cad0320..08d0382d76f 100644
--- a/backends/hostmem-file.c
+++ b/backends/hostmem-file.c
@@ -48,10 +48,6 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error
**errp)
g_autofree gchar *name = NULL;
uint32_t ram_flags;
- if (!backend->size) {
- error_setg(errp, "can't create backend with size 0");
- return false;
- }
if (!fb->mem_path) {
error_setg(errp, "mem-path property not set");
return false;
diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c
index 46489212a23..11d456e3ebd 100644
--- a/backends/hostmem-memfd.c
+++ b/backends/hostmem-memfd.c
@@ -49,11 +49,6 @@ memfd_backend_memory_alloc(HostMemoryBackend *backend, Error
**errp)
int fd = cpr_find_fd(name, 0);
uint32_t ram_flags;
- if (!backend->size) {
- error_setg(errp, "can't create backend with size 0");
- return false;
- }
-
if (fd >= 0) {
goto have_fd;
}
diff --git a/backends/hostmem-ram.c b/backends/hostmem-ram.c
index 6a507fad77c..0ae7b4ae759 100644
--- a/backends/hostmem-ram.c
+++ b/backends/hostmem-ram.c
@@ -22,11 +22,6 @@ ram_backend_memory_alloc(HostMemoryBackend *backend, Error
**errp)
g_autofree char *name = NULL;
uint32_t ram_flags;
- if (!backend->size) {
- error_setg(errp, "can't create backend with size 0");
- return false;
- }
-
name = host_memory_backend_get_name(backend);
ram_flags = backend->share ? RAM_SHARED : RAM_PRIVATE;
ram_flags |= backend->reserve ? 0 : RAM_NORESERVE;
diff --git a/backends/hostmem-shm.c b/backends/hostmem-shm.c
index adf60957c3c..0a01c760551 100644
--- a/backends/hostmem-shm.c
+++ b/backends/hostmem-shm.c
@@ -30,11 +30,6 @@ shm_backend_memory_alloc(HostMemoryBackend *backend, Error
**errp)
uint32_t ram_flags;
int fd = cpr_find_fd(backend_name, 0);
- if (!backend->size) {
- error_setg(errp, "can't create shm backend with size 0");
- return false;
- }
-
if (!backend->share) {
error_setg(errp, "can't create shm backend with `share=off`");
return false;
Reviewed-by: Mark Cave-Ayland <[email protected]>
ATB,
Mark.