On 11/11/2026 12:09 AM, Michael Tokarev wrote: > On 10/24/26 21:06, Brian Cain wrote: > >> --- a/roms/Makefile >> +++ b/roms/Makefile > >> +# Needs Hexagon SDK on PATH. >> +hexagon_h2_build := hexagon-firmware-build >> +hexagon_h2_src := $(CURDIR)/hexagon-hypervisor >> +hexagon_h2_out = $(CURDIR)/$(hexagon_h2_build) >> +hexagon_h2_booters := hexagon-booter-qcs6490-cdsp \ >> + hexagon-booter-sm8975-nsp hexagon-booter-sa8775p-cdsp \ >> + hexagon-booter-sc8480xp-nsp0 hexagon-booter-sa8797p-nsp0 >> +hexagon_h2_loadlinux := hexagon-loadlinux-qcs6490-cdsp \ >> + hexagon-loadlinux-sm8975-nsp hexagon-loadlinux-sa8775p-cdsp \ >> + hexagon-loadlinux-sc8480xp-nsp0 hexagon-loadlinux-sa8797p-nsp0 >> +hexagon_h2_common_flags = USE_PKW=0 TARGET=opt NULL_ANGEL_TRAP=1 \ >> + HMX_HLX_SUPPORT=1 \ >> + H2K_LOAD_ADDR=0x9b800000 H2K_GUEST_START=0xa2000000 \ >> + H2K_GIT_COMMIT=0x$(shell git -C hexagon-hypervisor rev-parse -- >> short=8 HEAD) \ >> + H2K_GIT_COMMIT_LONG=0x$(shell git -C hexagon-hypervisor rev-parse >> HEAD) \ >> + JFLAG=-j$(shell nproc) > > Can we get rid of the git thing here please? > > When a user downloads tarball from qemu download area and extracts it, > there's no git repository in there. So the above `git rev-parse` fails. > > I dunno if there should be official releases for the hexagon firmware or > we can create a file with some version string inside the subdir and use it > if exists (as we've done previously for some other roms, for exactly the > same reason). But the current version is not good :) > > (Testing 11.2.0-rc0 as a tarball, and noticed this immediately ;) > > Thanks, > > /mjt
Hi Michael, What is the use case to build from roms if you don't have access to git submodules to get sources for the projects? Any other rom build will fail, simply because submodules are not present. The difference in error message is subtly different (rev-parse failed vs 'no makefile found in subdir X'), but the result is the same: you can't build any rom that requires submodules. If we want something that works with a tarball, Makefile should do explicit git clone per project and not rely on submodules. Regards, Pierrick
