On Fri, 6 Nov 2026 at 16:36, Peter Maydell <[email protected]> wrote: > > The VMSTATE_PTIMER macro is defined to pass a 'version' argument of 1 > to VMSTATE_STRUCT_POINTER_TEST_V. This means that the field will > only be used in migration when the vmstate struct that uses > VMSTATE_PTIMER has a version_id of at least 1. This doesn't match > how we define other VMSTATE_FOO which don't take an explicit > version_id, which is to use a version argument of 0 (e.g. all the > common macros like VMSTATE_UINT32 are written to pass 0 to their > VMSTATE_UINT32_V counterparts, and so on). It also doesn't match > how we define VMSTATE_PTIMER_ARRAY. > > The practical effect of this is that users of VMSTATE_PTIMER in > vmstate structs which explicitly or implicitly have a version_id of 0 > were actually not getting their ptimers migrated.
As these are both reviewed I'm going to take the series via target-arm.next. -- PMM
