When a command container carries fewer than 5 parameters, usb_mtp_handle_data() passes the unset entries of params[] and fields of cmd to usb_mtp_command() uninitialized.
Zero-initialize both. Cc: [email protected] Fixes: 840a178c94db ("usb: mtp filesharing") Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4529 Suggested-by: Hui Peng <https://gitlab.com/benquike> Signed-off-by: Tommaso Califano <[email protected]> --- hw/usb/dev-mtp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 82de3ee401..f6f9bf52ed 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1890,9 +1890,9 @@ static void usb_mtp_get_data(MTPState *s, mtp_container *container, static void usb_mtp_handle_data(USBDevice *dev, USBPacket *p) { MTPState *s = USB_MTP(dev); - MTPControl cmd; + MTPControl cmd = { 0 }; mtp_container container; - uint32_t params[5]; + uint32_t params[5] = { 0 }; uint16_t container_type; int i, rc; -- 2.56.0
