Daniel P. Berrangé <[email protected]> writes:

> On Fri, Nov 13, 2026 at 08:41:35AM +0100, Markus Armbruster wrote:
>> Daniel P. Berrangé <[email protected]> writes:
>> 
>> > The MachineInfo struct is extended to report the list of aliases
>> > from the TYPE_ALIASED interface, in preference to the traditional
>> > alias from the TYPE_MACHINE struct.
>> >
>> > Initially we use 'alias' to fill the 'aliases' field in QOM. As
>> > machines get converted to set 'aliases', the first 'aliases'
>> > element will get used to fill 'alias. This provides backcompat
>> > during the transition phase.
>> >
>> > Signed-off-by: Daniel P. Berrangé <[email protected]>
>> 
>> [...]
>> 
>> > diff --git a/qapi/machine.json b/qapi/machine.json
>> > index 18d9dce849b..c25a492a4e8 100644
>> > --- a/qapi/machine.json
>> > +++ b/qapi/machine.json
>> > @@ -163,6 +163,8 @@
>> >  #
>> >  # @alias: an alias for the machine name
>> >  #
>> > +# @aliases: a list of aliases for the machine type name (since 12.0)
>> > +#
>> 
>> How are these two related?  Can one be present, and not the other?  If
>> both are present, does @alias always equal the first element of
>> @aliases?
>
> Yes, both are set, or neither are set. If set, @alias and @aliases[0]
> must always be identical.

Let's spell that out in the description.

>> @alias gets deprecated in PATCH 11.  Mention in the commit message?
>
> Sure
>
>> 
>> >  # @is-default: whether the machine is default
>> >  #
>> >  # @cpu-max: maximum number of CPUs supported by the machine type
>> > @@ -202,6 +204,7 @@
>> >  ##
>> >  { 'struct': 'MachineInfo',
>> >    'data': { 'name': 'str', '*alias': 'str',
>> > +            '*aliases': ['str'],
>> >              '*is-default': 'bool', 'cpu-max': 'int',
>> >              'hotpluggable-cpus': 'bool',  'numa-mem-supported': 'bool',
>> >              'deprecated': 'bool', '*default-cpu-type': 'str',
>> 
>
> With regards,
> Daniel


Reply via email to