From: zhuwei <[email protected]>

Hi,
The migrate_del_blocker() implementation in stubs/migr-blocker.c was an
empty no-op, while the real one in migration/migration.c takes ownership
of the Error from the migration blocker, frees it and then clears the
pointer:
    void migrate_del_blocker(Error **reasonp)
    {
        if (*reasonp) {
            ...
            error_free(*reasonp);
            *reasonp = NULL;
        }
    }
Command-line tools such as qemu-img link against the stub API.  Block
drivers like vmdk allocate a migration blocker Error during open() (see
error_setg() in vmdk_open(), "does not support live migration") and pass
it to migrate_add_blocker_normal().  Because the stub
migrate_add_blocker*() is a no-op it does not take ownership of the
Error, so on close the stub migrate_del_blocker() has to free it itself;
leaving the body empty leaks the error message.
This becomes visible when running under ASan: "qemu-img info foo.vmdk"
leaks the migration-blocker error and hangs / fails to exit when the
image is closed.
This patch frees the Error in the stub migrate_del_blocker() and sets
the pointer to NULL to match the semantics of the real implementation.
This also covers every other driver that uses a migration blocker
through the stub.

Thanks,
zhuwei
---
 stubs/migr-blocker.c | 7 +++++++
 1 file changed, 7 insertions(+)

Reply via email to