On 11/14/26 00:58, WX Chen wrote:
Did you mean TCG_COND_GEU? Surely dst very large results in vlmax.Hi Richard, Thanks for the review! I think TCG_COND_NE is correct here. The `dst` value actually comes from the previous `gen_helper_vsetvl(dst, tcg_env, ...);` call. According to the definition of the `vsetvli` instruction, it will set vl CSR and copy its value to a dst reg. The value of `vl` is determined by the relationship between AVL and VLMAX: AVL <= VLMAX: VL = AVL AVL < (2 * VLMAX): ceil(AVL / 2) ≤ VL ≤ VLMAX Otherwise: VL = VLMAX So, `dst` here is either equal to VLMAX or smaller than it. That's why TCG_COND_NE is used here.
Ok. I didn't follow the logic outside the patch context. r~
