Commit 4271f40383 ("virtio-net: correctly report maximum
tx_queue_size value") made virtio_net_device_realize() validate
tx_queue_size against virtio_net_max_tx_queue_size(), so the value
is already guaranteed not to exceed that limit when the subsequent

    n->net_conf.tx_queue_size = MIN(virtio_net_max_tx_queue_size(n),
                                    n->net_conf.tx_queue_size);

runs.  The MIN() can therefore never lower the value and is
redundant.  Drop it.

Signed-off-by: Wang Yechao <[email protected]>
---
 hw/net/virtio-net.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 36edb768b1..5d1d2e2d7c 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -4110,9 +4110,6 @@ static void virtio_net_device_realize(DeviceState *dev, 
Error **errp)
         error_printf("Defaulting to \"bh\"");
     }
 
-    n->net_conf.tx_queue_size = MIN(virtio_net_max_tx_queue_size(n),
-                                    n->net_conf.tx_queue_size);
-
     virtio_net_add_queue(n, 0);
 
     n->ctrl_vq = virtio_add_queue(vdev, 64, virtio_net_handle_ctrl);
-- 
2.27.0


Reply via email to