On 13/11/26 11:20, Philippe Mathieu-Daudé wrote:
On 13/11/26 10:59, Peter Maydell wrote:
On Tue, 10 Nov 2026 at 07:28, Philippe Mathieu-Daudé
<[email protected]> wrote:

On 9/11/26 15:23, Philippe Mathieu-Daudé wrote:
In round-robin (single-thread) TCG, all vCPUs share one
host thread, so qemu_cpu_is_self() is true for every vCPU.

The SEV helper used it to skip the kick of the issuing vCPU,
and so skipped it for every other vCPU too: a vCPU sleeping
in WFE is only woken when the RR kick timer fires.

Compare against the issuing vCPU instead.

Fixes: d238858bff60 ("target/arm: Implement WFE, SEV and SEVONPEND")
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
   target/arm/tcg/op_helper.c | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/arm/tcg/op_helper.c b/target/arm/tcg/op_helper.c
index 6a673e5ae6e8..173dd0e5151a 100644
--- a/target/arm/tcg/op_helper.c
+++ b/target/arm/tcg/op_helper.c
@@ -470,11 +470,11 @@ void HELPER(wfit)(CPUARMState *env, uint32_t rd)

   void HELPER(sev)(CPUARMState *env)
   {
-    CPUState *cs = env_cpu(env);
+    CPUState *self = env_cpu(env), *cs;

While rebasing I noticed I did that 1 week before latest ARM PR
and this conflicts with c5ec1bfad103 ("target/arm: don't pass env
to the sev helper"), then I noticed the previous 8def1f30d5d4
("target/arm: hold bql when SEV sets the event_register") which is
a distinct fix. This patch is still needed but need this to be
squashed now:

     -    CPUState *self = env_cpu(env), *cs;
     +    CPUState *self = current_cpu, *cs;

Or even simpler, check @current_cpu in place (no @self local var).

Generally speaking, I think we should avoid use of current_cpu
where we can -- it's an "action at a distance" global variable.

Besides, that would be the first use of @current_cpu in target/ !

If this function needs the CPU pointer for the current CPU then
we should revert c5ec1bfad103 so that we pass the env pointer
to the helper function again.

Thanks for the head up, I concur.




Reply via email to