Nagendran Jairam <[email protected]> writes:

> On Fri, Nov 20, 2026, 17:35 Alex Bennée <[email protected]> wrote:
>
>  Nagendran K <[email protected]> writes:
>
>  > Add support for loading Extended Tektronix HEX files through the
>  > generic loader.
>  >
>  > The loader parses Extended Tektronix records, validates their
>  > checksums, and loads the data at the addresses specified in the file.
>  >
>  > This allows Extended Tektronix files to be loaded directly without
>  > manual conversion to another supported format.
>  >
>  > Tested by loading an Extended Tektronix file containing a simple UART
>  > application on the RealView EB machine. The application executed
>  > successfully and produced the expected UART output.
>  >
>  > Signed-off-by: Nagendran K <[email protected]>
>
>  Ok before you send another version you should consider:
>
>    - split whitespace and comment updates into their own patches
>    - include a test case for the loader to show its use
>    - verify the whole series applies and builds cleanly on upstream's master 
> branch
>
>  And the cover letter for the series should also include what changes
>  you've made between each iteration. You can also include a summary of
>  updates under the --- in the commit messages.
>
>  -- 
>  Alex Bennée
>  Virtualisation Tech Lead @ Linaro
>
>    Ok sure, but where do I upload cover letter and testcase means the 
> baremetal build through which I tested or just overall summary
> of how did I test?

The cover letter is part of a multi-patch series, there is tooling you
can use to help prepare a series:

  
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#submitting-your-patches

For the testcase you can either publish a binary asset somewhere and
write a functional test:

  https://www.qemu.org/docs/master/devel/testing/functional.html

Or work out how to build one of the tcg tests and package it up as a hex
file and add a run to test it.

>      Nagendran 

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Reply via email to