On Mon, Aug 13, 2012 at 02:06:10PM +0200, Jan Kiszka wrote:
> On 2012-08-13 10:35, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <n...@linux-iscsi.org>
> >
> > This is required to get past the following assert with:
> >
> > commit 1523ed9e1d46b0b54540049d491475ccac7e6421
> > Author: Jan Kiszka <jan.kis...@siemens.com>
> > Date: Thu May 17 10:32:39 2012 -0300
> >
> > virtio/vhost: Add support for KVM in-kernel MSI injection
> >
> > Cc: Stefan Hajnoczi <stefa...@linux.vnet.ibm.com>
> > Cc: Jan Kiszka <jan.kis...@siemens.com>
> > Cc: Paolo Bonzini <pbonz...@redhat.com>
> > Cc: Anthony Liguori <aligu...@us.ibm.com>
> > Signed-off-by: Nicholas Bellinger <n...@linux-iscsi.org>
> > ---
> > hw/msix.c | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/hw/msix.c b/hw/msix.c
> > index 800fc32..c1e6dc3 100644
> > --- a/hw/msix.c
> > +++ b/hw/msix.c
> > @@ -544,6 +544,9 @@ void msix_unset_vector_notifiers(PCIDevice *dev)
> > {
> > int vector;
> >
> > + if (!dev->msix_vector_use_notifier &&
> > !dev->msix_vector_release_notifier)
> > + return;
> > +
> > assert(dev->msix_vector_use_notifier &&
> > dev->msix_vector_release_notifier);
> >
> >
>
> I think to remember pointing out that there is a bug somewhere in the
> reset code which deactivates a non-active vhost instance, no?
>
> Jan
Could not find it. Could you dig it up pls?
> --
> Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
> Corporate Competence Center Embedded Linux
