On 15 August 2012 20:58, Anthony Liguori <anth...@codemonkey.ws> wrote: > Peter Maydell <peter.mayd...@linaro.org> writes: >> On 15 August 2012 20:25, Alexander Graf <ag...@suse.de> wrote: >>> Nack from my POV. Too late for 1.2. Better get this in early for 1.3. > > No, it's not too late for 1.2. > > The release process is pretty clear. Major features needed to be posted > before August 1st. The late to get non-bug fixes in is today.
Yes. I don't think that means "it's OK to send out a patchset that isn't just doing cosmetic fixes to a generally OK previous version on the day of feature freeze and expect that people will have time to review it". Basically, if this wasn't freeze day I'd expect a patchseries like this to sit on the list for at least three days or so for review. Saying "nack" here is a stake in the ground to say "this shouldn't be committed just because it happens to be freeze day today". > This is not a major feature but more importantly, has gone through a few > revisions and has gotten positive review comments. Anything touching 50 files is "major feature" IMHO, and the first version of this patchset went out just 6 days ago. Short rc phases only work if people are reasonably sensible about not putting in enormous numbers of patches right at the freeze deadline, IMHO. This patchset doesn't meet the "value obtained for amount of disruption / quality of review" bar for me, is all. -- PMM
