On 19 August 2012 11:12, Avi Kivity <a...@redhat.com> wrote: > On 08/17/2012 10:41 AM, liu ping fan wrote: >> And something like omap_mpu_timer_init() in file hw/omap1.c , the >> opaque(omap_mpu_timer_s) is got from g_malloc0, which makes things >> even harder to handle. And the DO_CAST can not work for such issue. > > IMO omap_mpu_timer_s should be a DeviceState. Peter?
Ideally, yes, but qemu is full of devices that haven't yet made the leap to QOM. omap1 is particularly tricky because I don't actually have any test images for it, so refactoring it is a leap in the dark. [I've tried asking on this list if anybody had test images a couple of times without success.] -- PMM
