On 23 August 2012 01:08, BALATON Zoltan <bala...@eik.bme.hu> wrote: > Division with round up is the correct way to compute this even if the > only case where division with round down gives incorrect result is > probably 15 bpp. This case was explicitely patched up in one of these > functions but was unhandled in the other. This patch also adds the > missing cases and aborts for invalid unhandled cases. (I'm not sure > about setting 16 bpp for the 15 bpp case so I left it there for now.) > > Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu> > --- > console.c | 230 > +++++++++++++++++++++++++++++++++++-------------------------- > 1 file changed, 131 insertions(+), 99 deletions(-)
It's a bit hard to see what's actually been changed in this patch -- can you split it up into a patch that fixes the switch indent first (and which has only whitespace changes, so 'git diff -w' produces no output for it), and then a patch making the actual changes, please? (A useful rule of thumb, incidentally, is that if you find yourself writing "also" in a commit message you should consider splitting it into two separate commits instead :-)) thanks -- PMM
