On Fri, Aug 24, 2012 at 01:56:31PM +0200, Paolo Bonzini wrote: > Il 24/08/2012 11:55, Peter Maydell ha scritto: > >> > OpenBSD's uname works as expected with the -s flag so remove the special > >> > handling when determining the target OS. Use arch -s to retrieve the > >> > hardware architecture as uname -m will return the meta architecture > >> > instead of the hardware architecture (.e.g. macppc vs powerpc). > > I'm afraid I think this patch is moving in the wrong direction. > > Wherever possible we should be using compiler checks like check_define, > > not looking at the output of 'uname' and the like. The former will > > work when cross compiling, and the latter will give the wrong answers. > > In some places we have that kind of 'look at uname/etc' check but > > we should be trying to reduce and eliminate it where possible. > > Right, we should support GNU triplets and a --host argument, and replace > uname checks with pattern matching on the triplet.
That still requires a means of generating that triplet in the first place. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
