On 26 August 2012 15:14, Aurelien Jarno <aurel...@aurel32.net> wrote: > Altivec instructions are not working anymore in PowerPC emulation, > following commit d15f74fb, which inverted two registers in the call > to helper. Fix that. > > Cc: Blue Swirl <blauwir...@gmail.com> > Cc: Alexander Graf <ag...@suse.de> > Cc: Andreas Färber <afaer...@suse.de> > Signed-off-by: Aurelien Jarno <aurel...@aurel32.net> > --- > target-ppc/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index 91eb7a0..ac915cc 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -6530,7 +6530,7 @@ static void glue(gen_, name)(DisasContext *ctx) > \ > ra = gen_avr_ptr(rA(ctx->opcode)); \ > rb = gen_avr_ptr(rB(ctx->opcode)); \ > rd = gen_avr_ptr(rD(ctx->opcode)); \ > - gen_helper_##name(rd, cpu_env, ra, rb); \ > + gen_helper_##name(cpu_env, rd, ra, rb); \ > tcg_temp_free_ptr(ra); \ > tcg_temp_free_ptr(rb); \ > tcg_temp_free_ptr(rd); \
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> (For these helpers, rd is an input to the helper, not an output, which is why the cpu_env has to go first, unlike eg gen_helper_mulldo().) -- PMM
