On Thu, 30 Aug 2012 09:41:55 +0200 Paolo Bonzini <pbonz...@redhat.com> wrote:
> Il 30/08/2012 08:49, Igor Mammedov ha scritto: > >>> > > +static void qemu_system_powerdown(void) > > this is a bad naming that conflicts with global var qemu_system_powerdown, > > so > > bisectability of series is still broken. > > perhaps qemu_do_system_powerdown() would be better for function name, > > although it doesn't match common name pattern used for this kind of > > functions. > > > > Just inline the function in this patch, and uninline it later. Thanks, fixed in https://github.com/imammedo/qemu/tree/cpu_as_device.WIP > > Paolo > -- Regards, Igor
