Am 31.08.2012 19:30, schrieb Eric Blake: > On 08/31/2012 10:26 AM, Daniel P. Berrange wrote: >> From: "Daniel P. Berrange" <berra...@redhat.com> >> >> The encryption password is only required if I/O is going to be >> performed on a disk image. The 'qemu-img info' command merely >> reports metadata, so it should not ask for a decryption password >> >> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> >> --- >> qemu-img.c | 21 +++++++++++---------- >> 1 file changed, 11 insertions(+), 10 deletions(-) >> >> diff --git a/qemu-img.c b/qemu-img.c >> index b41e670..3dd4ec7 100644 >> --- a/qemu-img.c >> +++ b/qemu-img.c >> @@ -221,7 +221,8 @@ static int print_block_option_help(const char *filename, >> const char *fmt) >> >> static BlockDriverState *bdrv_new_open(const char *filename, >> const char *fmt, >> - int flags) >> + int flags, >> + int requireIO) > > Since you only pass 0 or 1 for requireIO, why not make it bool?
Yes, please. bool require_io, to be precise. The qemu coding style doesn't use camelCase here. > For > that matter, why not make it part of 'flags', where the default is to > require decryption, and a new flag BDV_O_NO_IO can be added when opening > an image for no I/O and used to avoid the decryption? Because the block layer isn't really interested in it, this should be kept inside qemu-img. Kevin
