On Thu, Sep 6, 2012 at 10:32 AM, Andreas Färber <afaer...@suse.de> wrote: > Am 05.09.2012 21:46, schrieb Blue Swirl: >> Thanks, applied all. > > Question: Are additions to checkpatch.pl supposed to be in QEMU Coding > Style as done here? Do you plan to convert it consistently then? > checkpatch.pl uses tabs consistently, making checkpatch.pl complain. ;) > The alternative would be to stick to upstream formatting and exempt > checkpatch.pl from its own checks.
I'd suppose checkpatch.pl can't check Perl, Python or sh syntax so we could try to limit some of the checks to C files only. For example tabs are mandatory as the initial character for Makefile rules, we could in theory demand spaces otherwise but I guess nobody cares enough to add checks for this. > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg