On 12 September 2012 14:20, Laurent Desnogues <laurent.desnog...@gmail.com> wrote: > Sorry, I had missed this patch... > > On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost <ehabk...@redhat.com> wrote: >> commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for >> comma-separated target lists on the --target-list option. e.g.: >> >> $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu >> [...] >> ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised >> $ >> >> This patch restores that ability. >> >> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> >> Cc: Daniel P. Berrange <berra...@redhat.com> >> Cc: Anthony Liguori <anth...@codemonkey.ws> >> --- >> configure | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/configure b/configure >> index 7656c32..9ee7038 100755 >> --- a/configure >> +++ b/configure >> @@ -1323,7 +1323,9 @@ if ! "$python" -c 'import sys; >> sys.exit(sys.version_info < (2,4) or sys.version_ >> fi >> >> if test "$target_list" = "DEFAULT" ; then >> - target_list=`echo "$default_target_list" | sed -e 's/,/ /g'` >> + target_list="$default_target_list" >> +else >> + target_list=`echo "$target_list" | sed -e 's/,/ /g'` >> fi > > This works for me too. > > But I still can't get what the original patch posted by > Daniel Berrange intended to do: > > $ ./configure --target-list= > $ make V=1 > cat | grep =y | sort -u > config-all-devices.mak > > And it of course hangs there.
Hmm. Perhaps we should just revert 66d5499b3 and then recommit a working implementation later? -- PMM