On Fri, Sep 14, 2012 at 03:17:52PM +0200, Paolo Bonzini wrote: > Hi all, > > here is a proposal for moving around 150 C files currently in the > toplevel directory to separate, well-delimited subdirectories. Header > files would be moved for now in include/, preparing for subsequent > reorganization of headers.
I tend to view usage of a separate 'include/' subdirectory as a location for public facing header files. For internal header files, IMHO, its nicer to just have them alongside the .c file which has the corresponding implementation. I know QEMU has traditionally been a bit wierd having giant header files containing decls that are then implemented across a whole set of source files. Perhaps it is worthwhile to focus on santizing the headers rather than moving them elsewhere where there's even less incentive to keep header + source filenames aligned. > Usually the files would keep their names, but I loathe names starting > with qemu-* so I took the occasion to rename those. Heh, I would have suggested the opposite - use a 'qemu-' prefix on every single file, mostly so that you avoid the confusion where a source-local header file happens to have same name as a public header file in /usr/include. > This does not touch the hw/ directory, which is its own mess and worth a > separate discussion. Cleaning it up may require introducing more > CONFIG_* symbols and moving stuff to libhw whenever possible (for > example if we want all NICs in hw/net, all RTCs in hw/rtc, etc. perhaps > with some exceptions for USB). > > Opinions, flames, "stop this guy"s are welcome as usual. I appauld your amibition to modularize the source tree layout more. Even if you disagree with my POV on the issues above, it would be an improvement. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|