Am 18.09.2012 16:33, schrieb Paolo Bonzini: > Il 18/09/2012 13:40, Kevin Wolf ha scritto: >> static void run_dependent_requests(BDRVQcowState *s, QCowL2Meta *m) >> { >> - /* Take the request off the list of running requests */ >> - if (m->nb_clusters != 0) { >> - QLIST_REMOVE(m, next_in_flight); >> - } >> - >> /* Restart all dependent requests */ >> if (!qemu_co_queue_empty(&m->dependent_requests)) { >> - qemu_co_mutex_unlock(&s->lock); >> qemu_co_queue_restart_all(&m->dependent_requests); >> - qemu_co_mutex_lock(&s->lock); >> } > > The comment and if can go away.
Ah, yes. And the one remaining line can be open coded in the two callers. > Perhaps this patch could be moved earlier in the series? (Just asking, > in case the rebase is not too painful). I'll check how painful it becomes. I'd expect it's doable. Kevin